Optimize Enumerable.Min/Max<T> for value types with Comparer<T>.Default intrinsic #48273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stephentoub
commented
Feb 14, 2021
stephentoub
commented
| Method | Toolchain | Count | Mean | Ratio |
|---|---|---|---|---|
| Max | \master\corerun.exe | 10 | 70.12 ns | 1.00 |
| Max | \pr\corerun.exe | 10 | 56.19 ns | 0.80 |
| Min | \master\corerun.exe | 10 | 67.45 ns | 1.00 |
| Min | \pr\corerun.exe | 10 | 54.85 ns | 0.81 |
| Max | \master\corerun.exe | 1000000 | 6,007,980.36 ns | 1.00 |
| Max | \pr\corerun.exe | 1000000 | 4,666,923.86 ns | 0.78 |
| Min | \master\corerun.exe | 1000000 | 5,492,475.28 ns | 1.00 |
| Min | \pr\corerun.exe | 1000000 | 4,401,151.26 ns | 0.80 |
|
Tagging subscribers to this area: @eiriktsarpalis Issue Details
[Params(10, 1_000_000)]
public int Count { get; set; }
[GlobalSetup]
public void Setup()
{
var r = new Random();
_times = Enumerable.Range(0, Count).Select(_ => TimeSpan.FromMilliseconds(r.Next(0, int.MaxValue))).ToArray();
}
private TimeSpan[] _times;
[Benchmark]
public TimeSpan Max() => _times.Max();
[Benchmark]
public TimeSpan Min() => _times.Min();
|
jkotas
approved these changes
Feb 14, 2021
drieseng
reviewed
Feb 14, 2021
Member
Author
|
Thanks, @EgorBo ;-) |
|
What about optimizing the case for |
Member
Author
|
| } | ||
| while (value == null); | ||
|
|
||
| Comparer<TSource> comparer = Comparer<TSource>.Default; |
Member
There was a problem hiding this comment.
Out of curiosity, what is the motivation for not optimizing reference types?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.