Fix using .NET COM server with dynamic keyword
#48037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronRobinsonMSFT
approved these changes
Feb 9, 2021
Member
AaronRobinsonMSFT
left a comment
AaronRobinsonMSFT
left a comment
There was a problem hiding this comment.
LGTM.
@elinor-fung we spoke offline about this and I agree porting this back to .NET 5 doesn't seem to much effort and probably worth it. We would likely need a user impact request though.
Member
Author
|
Ergh. I guess the |
This was referenced Feb 9, 2021
elinor-fung
force-pushed
the
dynamicNetServer
branch
from
fc88596 to
a9195ee
Compare
AaronRobinsonMSFT
approved these changes
Feb 10, 2021
elinor-fung
added a commit
to elinor-fung/runtime
that referenced
this pull request
Feb 18, 2021
Anipik
pushed a commit
that referenced
this pull request
Mar 10, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDispatch::GetTypeInfoCountreturning a count of 0 as not supporting type info (even when the returned HRESULT is failure)ImportedFromTypeLibFixes #47329
cc @AaronRobinsonMSFT @jkoritzinsky