Fix SuperPMI collection with crossgen2 #47751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crossgen2 abuses the `CORINFO_SIG_INFO.pSig` field by treating it as an opaque handle/pointer, and not a pointer to an array of signature bytes. Work around this by detecting this case and storing/restoring the pointer instead of a signature byte array. Also, add and improve some dump functions. Mostly fixes dotnet#47540 (Fixes it to about the same level of failures in crossgen1 compilations.)
ghost
added
the
area-CodeGen-coreclr
Contributor
Author
|
cc @dotnet/jit-contrib @dotnet/crossgen-contrib |
Add logging variables, but leave them under #if 0 Fix handling of getCallInfo throwing an exception.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crossgen2 abuses the
CORINFO_SIG_INFO.pSigfield by treatingit as an opaque handle/pointer, and not a pointer to an array
of signature bytes. Work around this by detecting this case
and storing/restoring the pointer instead of a signature byte
array.
Also, add and improve some dump functions.
Mostly fixes #47540
(Fixes it to about the same level of failures in crossgen1
compilations.)
Change the JIT-EE interface to force a re-collection, due to
breaking SuperPMI data file format change.