Add MemoryMarshal.CreateReadOnlySpanFromNullTerminated #47539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
GrabYourPitchforks
approved these changes
Jan 27, 2021
src/libraries/System.Memory/tests/MemoryMarshal/CreateReadOnlySpanFromNullTerminated.cs
Outdated
Show resolved
Hide resolved
stephentoub
force-pushed
the
spanterminated
branch
2 times, most recently
from
cbc90a1 to
4888b01
Compare
ahsonkhan
reviewed
Jan 27, 2021
src/libraries/System.Memory/tests/MemoryMarshal/CreateReadOnlySpanFromNullTerminated.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+220
to
+221
Contributor
There was a problem hiding this comment.
We'd want to port these changes to the actual docs site.
https://docs.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.memorymarshal.createspan?view=net-5.0
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/MemoryMarshal.cs
Outdated
Show resolved
Hide resolved
ahsonkhan
reviewed
Jan 28, 2021
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/MemoryMarshal.cs
Outdated
Show resolved
Hide resolved
ahsonkhan
approved these changes
Jan 28, 2021
jkotas
reviewed
Jan 28, 2021
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/MemoryMarshal.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Jan 28, 2021
stephentoub
force-pushed
the
spanterminated
branch
from
1369bd5 to
7040d07
Compare
stephentoub
commented
Jan 29, 2021
Member
Author
|
/azp list |
Member
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40202
cc: @jkotas, @GrabYourPitchforks