[Mono][LLVM][ARM] Implemented Arm64 Abs intrinsic #47482
Conversation
naricc
requested review from
CoffeeFlux,
EgorBo,
SamMonoRT,
imhameed,
lambdageek and
vargaz
as code owners
ghost
added
the
area-CodeGen-coreclr
naricc
changed the title
src/mono/mono/mini/mini-llvm.c
Outdated
There was a problem hiding this comment.
The whole function looks like the work to define signatures for intrinsics could be done via macros in llvm-intrinsics.h instead.
There was a problem hiding this comment.
Do we have macros to do this type of thing, or were you suggesting I create some? I would have think think a little about how to do it; this function predates my changes and would need some reworking.
There was a problem hiding this comment.
Yeah, I mean in general, if you want to eventually implement the full set of intrinsics it makes sense to minimize verbosity of the changes.
naricc
force-pushed
the
naricc/arm-simd-intrinsics
branch
from
07c77da to
cd96ca9
Compare
naricc
force-pushed
the
naricc/arm-simd-intrinsics
branch
from
23828a7 to
5c4dd0d
Compare
kunalspathak
left a comment
kunalspathak
left a comment
There was a problem hiding this comment.
LGTM. So this is the first AdvSimd.Arm64 API that is being supported in mono?
Yes. I am working on implement more; the issue listing them all is here: #42266 |
Got it. I have added a reference to the documentation that I worked few months back to explain what every AdvSimd.Arm64 intrinsic API does. In case it is helpful to you or anyone working on this feature. |
ghost
locked as resolved and limited conversation to collaborators
6 participants
Implements AdvSimd.Abs intrinsic on arm64 with LLVM.