Clean up aspnetcore casing in ref to that repo
#47347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dougbu
commented
Jan 22, 2021
dougbu
commented
- address difference I introduced in Mention 'main' instead of 'master' aspnetcore#29511 and more
- conflict detected in Sync shared code from runtime aspnetcore#29520
- also s|aspnet/aspnetcore|dotnet/aspnetcore|
- address difference I introduced in dotnet/aspnetcore#29511 and more - conflict detected in dotnet/aspnetcore#29520 - also s|aspnet/aspnetcore|dotnet/aspnetcore|
dougbu
requested review from
a team,
NikolaMilosavljevic,
Tratcher and
dotnet-bot
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Contributor
Author
|
Looks like VS Code removed a fair amount of trailing whitespace. Let me know if you prefer I revert that noise. |
Tratcher
approved these changes
Jan 22, 2021
Member
Tratcher
left a comment
Tratcher
left a comment
There was a problem hiding this comment.
Fixes dotnet/aspnetcore#18943
|
Tagging subscribers to this area: @dotnet/ncl Issue Details
|
stephentoub
approved these changes
Jan 22, 2021
Contributor
Author
|
Ah, I have permissions to merge as long as I don't use a fork 😃 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.