Skip to content

Fix threading issue in MulticoreJit #46783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkotas merged 1 commit into from
Jan 12, 2021
Merged

Fix threading issue in MulticoreJit #46783

jkotas merged 1 commit into from
Jan 12, 2021

Conversation

@clamp03
Copy link
Member

@clamp03 clamp03 commented Jan 9, 2021

Fix #46778 issue

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 9, 2021
@clamp03
Copy link
Member Author

clamp03 commented Jan 9, 2021

It writes a profile file once (default is 12 seconds after a first method is recorded ) while an application is running. It may block execution for a long time.

@jkotas jkotas added area-TieredCompilation-coreclr and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Jan 9, 2021
@clamp03
Copy link
Member Author

clamp03 commented Jan 12, 2021

@jkotas Could you review?
PlayerLock is locked before StopProfile in WriteMulticoreJitProfiler like others. Actually, I concern about the execution block. If you have any other way, please share.
And does it really need to write a profile while an application runs in non-unix? If possible, I want to remove it.

@jkotas
Copy link
Member

jkotas commented Jan 12, 2021

And does it really need to write a profile while an application runs in non-unix?

I suspect that there are applications out there that depend on this behavior on Windows. We would need to go through the breaking change process to delete this delayed write.

jkotas
jkotas approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for fixing this

@jkotas jkotas merged commit 7ffe282 into dotnet:master Jan 12, 2021
@clamp03 clamp03 deleted the fixMCJ branch January 12, 2021 08:50
@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas approved these changes

Assignees

No one assigned

Labels

area-TieredCompilation-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MulticoreJIT accesses m_GenericInfoCount field from multiple threads without synchronization

3 participants

@clamp03 @jkotas @Dotnet-GitSync-Bot