Skip to content

Conversation

@MihaZupan
Copy link
Member

@MihaZupan MihaZupan commented Jan 8, 2021

This PR extracts a portion of changes from #34864 to help simplify the review process. As such, #34864 depends on this change.

Uri behavior should remain completely unchanged.

Note: Make sure to Hide whitespace changes when reviewing this change

@MihaZupan MihaZupan added this to the 6.0.0 milestone Jan 8, 2021
@MihaZupan MihaZupan requested review from a team and alnikola January 8, 2021 15:44
@ghost
Copy link

ghost commented Jan 8, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR extracts a portion of changes from #34864 to help simplify the review process. As such, #34864 depends on this change.

Uri behavior should remain completely unchanged.

Author: MihaZupan
Assignees: -
Labels:

area-System.Net

Milestone: 6.0.0

@MihaZupan MihaZupan added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 11, 2021
@MihaZupan
Copy link
Member Author

Adding no-merge while I'm looking into some weirdness in original code.
We may be lacking test coverage here.

Copy link
Contributor

@alnikola alnikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MihaZupan MihaZupan removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 18, 2021
@MihaZupan MihaZupan merged commit 8837b19 into dotnet:master Jan 18, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants