Simplify Uri UnicodeEquivalent helper #46747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis PR extracts a portion of changes from #34864 to help simplify the review process. As such, #34864 depends on this change. Rewrite the
Aside from performance characteristics, Uri behavior should remain completely unchanged.
|
MihaZupan
commented
Jan 8, 2021
| unsafe | ||
| stemp = UriHelper.StripBidiControlCharacters(stemp, stemp); | ||
|
|
||
| var hostBuilder = new ValueStringBuilder(stackalloc char[512]); |
Member
Author
There was a problem hiding this comment.
512 is used as that is the value of the StackallocThreshold constant being introduced in #34864.
| // but we shouldn't throw after the constructor. | ||
| catch (UriFormatException) { } | ||
| } | ||
| stemp = hostBuilder.ToString(); |
Member
Author
There was a problem hiding this comment.
This allocation could be avoided, but that is being done in #34864 and this PR is not introducing new allocations.
stephentoub
approved these changes
Jan 8, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts a portion of changes from #34864 to help simplify the review process. As such, #34864 depends on this change.
Rewrite the
UnicodeEquivalenthelper method intoTryGetUnicodeEquivalent, changing:ValueStringBuilderAside from performance characteristics, Uri behavior should remain completely unchanged.