Skip to content

Fix assert(isByteReg(ireg)). #46567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sandreenko merged 1 commit into from
Jan 6, 2021
Merged

Fix assert(isByteReg(ireg)). #46567

sandreenko merged 1 commit into from
Jan 6, 2021

Conversation

@sandreenko
Copy link
Contributor

@sandreenko sandreenko commented Jan 5, 2021 •
edited
Loading

We had a similar code in the non-multi reg case:

runtime/src/coreclr/jit/lsrabuild.cpp

Lines 3380 to 3386 in 867ba80

#ifdef TARGET_X86
var_types type = varDsc->GetRegisterType(storeLoc);
if (varTypeIsByte(type))
{
srcCandidates = allByteRegs();
}
#endif // TARGET_X86

so repeat the logic for MultiReg.

When we do a call we then copy the arguments to the temp location and we should choose registers that can be used in byte instructions on x86.

Fixes #46277.

No diffs.

@sandreenko sandreenko added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 5, 2021
@sandreenko
Copy link
Contributor Author

sandreenko commented Jan 5, 2021

/azp run runtime-coreclr outerloop, runtime-coreclr jitstressregs

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 5, 2021

Azure Pipelines successfully started running 2 pipeline(s).

@sandreenko
Copy link
Contributor Author

sandreenko commented Jan 5, 2021

PTAL @dotnet/jit-contrib , cc @jkoritzinsky

@sandreenko
Copy link
Contributor Author

sandreenko commented Jan 5, 2021

/azp run runtime-coreclr jitstressregs

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 5, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@BruceForstall BruceForstall self-requested a review January 5, 2021 18:49
kunalspathak
kunalspathak approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However, I am wondering what changed that we hit issue #46277? I see that the assert in the issue was added last year in 9781175?

@sandreenko
Copy link
Contributor Author

sandreenko commented Jan 5, 2021

Looks good to me. However, I am wondering what changed that we hit issue #46277? I see that the assert in the issue was added last year in 9781175?

It was exposed by #39294, before Jit did not see struct returns like <int, byte> on x86.

@sandreenko
Copy link
Contributor Author

sandreenko commented Jan 6, 2021

The failures in the stress job are covered by #46085.

@sandreenko sandreenko merged commit c0ca958 into dotnet:master Jan 6, 2021
@sandreenko sandreenko deleted the fixByteRegx86 branch January 6, 2021 01:58
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

@kunalspathak kunalspathak kunalspathak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arch-x86 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test failure: Assertion failed 'isByteReg(ireg)' in 'StructABI:EchoByteAndFloatWrapper():bool' during 'Generate code'

3 participants

@sandreenko @BruceForstall @kunalspathak