Add variable lifetime update for GT_STOREIND for arm/arm64#46059
Merged
BruceForstall merged 1 commit intodotnet:masterfrom Dec 18, 2020
Merged
Add variable lifetime update for GT_STOREIND for arm/arm64#46059BruceForstall merged 1 commit intodotnet:masterfrom
BruceForstall merged 1 commit intodotnet:masterfrom
Conversation
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
Contributor
Author
|
/azp list |
Contributor
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
gcstress failures are 2 timeouts in Linux arm, and 2 failures of #45090 |
Contributor
Author
|
@sandreenko @dotnet/jit-contrib PTAL |
Contributor
Author
|
asm diffs for arm64 are essentially the same as for xarch in #45557; extended GC lifetimes where previously they were cut short. |
AndyAyersMS
approved these changes
Dec 15, 2020
Member
AndyAyersMS
left a comment
AndyAyersMS
left a comment
There was a problem hiding this comment.
We should port this to 5.0 as well.
Fix dotnet#45557 for arm/arm64 Fixes dotnet#46023
BruceForstall
force-pushed
the
Fix45557arm
branch
from
e9207ee to
f9f57d1
Compare
Contributor
Author
|
I verified that the Linux arm libraries crossgen SPMI asm diffs show the same pattern of fixes: adding stack slots to the tracked GC refs set for a short range. |
BruceForstall
added a commit
to BruceForstall/runtime
that referenced
this pull request
Dec 18, 2020
Port dotnet#46059 to release/5.0 Fix dotnet#45557 for arm/arm64 Fixes dotnet#46023
Anipik
pushed a commit
that referenced
this pull request
Jan 14, 2021
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #45557 for arm/arm64
Fixes #46023