[release/5.0] P/Invoke function returning SafeSocketHandle throws MissingMethodException (#45911)#45942
Merged
eerhardt merged 2 commits intodotnet:release/5.0from Dec 11, 2020
Merged
Conversation
…ption (dotnet#45911) * P/Invoke function returning SafeSocketHandle throws MissingMethodException The ILLinker is trimming the private default constructors of SafeHandle classes if they are not used by the library. Adding an XML descriptor file to preserve the private constructors of these SafeHandles so they can be used in P/Invokes in external code. Fix dotnet#45633 Suppress P/Invoke test on Browser
eerhardt
requested review from
AaronRobinsonMSFT,
jkotas,
marek-safar and
stephentoub
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsDescriptionThe ILLinker is trimming the private default constructors of SafeHandle classes if they are not used by the library. Adding an XML descriptor file to preserve the private constructors of these SafeHandles so they can be used in P/Invokes in external code. Customer ImpactIf an app is using SafeSocketHandle as the return of a P/Invoke and upgrades from 3.1 to 5.0, the app is broken with TestingAdded 2 new tests for the SafeHandles identified as problematic to ensure customers can P/Invoke using these classes. RiskLow Fix #45633
|
jkotas
approved these changes
Dec 11, 2020
AaronRobinsonMSFT
approved these changes
Dec 11, 2020
jeffschwMSFT
approved these changes
Dec 11, 2020
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Approved. We should consider this for 5.0.2
Member
Author
|
This is broken in the release/5.0 branch because of some build infrastructure differences between master and release/5.0. (Thank you, tests!) Working on a fix. |
…astructure expects them.
Member
Author
|
The single test failure is #43981. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ILLinker is trimming the private default constructors of SafeHandle classes if they are not used by the library. Adding an XML descriptor file to preserve the private constructors of these SafeHandles so they can be used in P/Invokes in external code.
Customer Impact
If an app is using SafeSocketHandle as the return of a P/Invoke and upgrades from 3.1 to 5.0, the app is broken with
System.MissingMethodException: .ctor. There isn't a workaround other than not usingSafeSocketHandlein the P/Invoke signature.Testing
Added 2 new tests for the SafeHandles identified as problematic to ensure customers can P/Invoke using these classes.
Risk
Low
Fix #45633