P/Invoke function returning SafeSocketHandle throws MissingMethodException#45911
Merged
eerhardt merged 3 commits intodotnet:masterfrom Dec 11, 2020
Merged
P/Invoke function returning SafeSocketHandle throws MissingMethodException#45911eerhardt merged 3 commits intodotnet:masterfrom
eerhardt merged 3 commits intodotnet:masterfrom
Conversation
…ption The ILLinker is trimming the private default constructors of SafeHandle classes if they are not used by the library. Adding an XML descriptor file to preserve the private constructors of these SafeHandles so they can be used in P/Invokes in external code. Fix dotnet#45633
eerhardt
requested review from
AaronRobinsonMSFT,
jkotas,
marek-safar and
stephentoub
AaronRobinsonMSFT
approved these changes
Dec 10, 2020
marek-safar
approved these changes
Dec 10, 2020
Suppress P/Invoke test on Browser
Member
Author
|
Failure is #44657 |
Member
Author
|
/backport to release/5.0 |
Contributor
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/414427274 |
Contributor
|
@eerhardt backporting to release/5.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: P/Invoke function returning SafeSocketHandle throws MissingMethodException
error: sha1 information is lacking or useless (src/libraries/System.IO.MemoryMappedFiles/tests/System.IO.MemoryMappedFiles.Tests.csproj).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 P/Invoke function returning SafeSocketHandle throws MissingMethodException
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
eerhardt
added a commit
to eerhardt/runtime
that referenced
this pull request
Dec 11, 2020
…ption (dotnet#45911) * P/Invoke function returning SafeSocketHandle throws MissingMethodException The ILLinker is trimming the private default constructors of SafeHandle classes if they are not used by the library. Adding an XML descriptor file to preserve the private constructors of these SafeHandles so they can be used in P/Invokes in external code. Fix dotnet#45633 Suppress P/Invoke test on Browser
eerhardt
added a commit
that referenced
this pull request
Dec 11, 2020
…singMethodException (#45911) (#45942) * P/Invoke function returning SafeSocketHandle throws MissingMethodException (#45911) The ILLinker is trimming the private default constructors of SafeHandle classes if they are not used by the library. Adding an XML descriptor file to preserve the private constructors of these SafeHandles so they can be used in P/Invokes in external code. Fix #45633 Suppress P/Invoke test on Browser cherry-pick of af1b1ad * Move ILLinkTrim files to the .csproj folder, where the 5.0 build infrastructure expects them.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ILLinker is trimming the private default constructors of SafeHandle classes if they are not used by the library. Adding an XML descriptor file to preserve the private constructors of these SafeHandles so they can be used in P/Invokes in external code.
Fix #45633