Delay initialization of Task related properties which are rarely used #45127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to reduce the dependencies chain
jkotas
reviewed
Nov 23, 2020
src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 24, 2020
src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 24, 2020
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
With the suggested changes, LGTM.
jkotas
reviewed
Nov 24, 2020
src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 24, 2020
src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs
Show resolved
Hide resolved
stephentoub
reviewed
Nov 24, 2020
src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Nov 24, 2020
…utionContext.cs Co-authored-by: Stephen Toub <[email protected]>
jkotas
approved these changes
Nov 24, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to reduce the dependencies chain