Fix arm64 disasm failures#44547
Merged
BruceForstall merged 1 commit intodotnet:masterfrom Nov 12, 2020
Merged
Conversation
GTF_ICON_STATIC_HDL and GTF_ICON_FTN_ADDR can't be converted to names using eeGetFieldName and eeGetMethodFullName, respectively. So, just print out the type of the target. Fixes dotnet#40354
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
Contributor
Author
|
@kunalspathak PTAL |
echesakov
approved these changes
Nov 11, 2020
kunalspathak
approved these changes
Nov 11, 2020
Contributor
kunalspathak
left a comment
kunalspathak
left a comment
There was a problem hiding this comment.
Thanks for fixing this.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GTF_ICON_STATIC_HDL and GTF_ICON_FTN_ADDR can't be converted
to names using eeGetFieldName and eeGetMethodFullName, respectively.
So, just print out the type of the target.
Fixes #40354