Add a PNSE configuration for System.Net.Quic #44223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Systme.Net.Quic is part of the shared framework but dosn't have a configuration that applies to Browser. Adding a non-rid configuration so that this applies for all future configurations that aren't explicitely listed as well. Changing some throw null lambdas in the reference source file to work around a bug in the GenFacades not supported assembly creation logic: dotnet/arcade#6509.
|
Tagging subscribers to this area: @dotnet/ncl |
stephentoub
reviewed
Nov 3, 2020
Member
Author
Member
I've very recently chatted with the team, there are ongoing load issues they're resolving which likely are causing this. If it starts being 100% we can certainly IcM it but they are actively fighting fires now. |
Anipik
approved these changes
Nov 4, 2020
safern
approved these changes
Nov 4, 2020
Member
Author
|
@jkoritzinsky your PR's closure validation (?) should be unblocked now. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Systme.Net.Quic is part of the shared framework but dosn't have a
configuration that applies to Browser. Adding a non-rid configuration so
that this applies for all future configurations that aren't explicitely
listed as well.
Changing some throw null lambdas in the reference source file to work
around a bug in the GenFacades not supported assembly creation logic:
dotnet/arcade#6509.
Fixes #44192