Skip to content

Remove some unnecessary List-related allocation from EventSource #44026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephentoub merged 1 commit into from
Oct 29, 2020
Merged

Remove some unnecessary List-related allocation from EventSource #44026

stephentoub merged 1 commit into from
Oct 29, 2020

Conversation

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Oct 29, 2020

Fixes #43989

@ghost
Copy link

ghost commented Oct 29, 2020

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

@tarekgh
Copy link
Member

tarekgh commented Oct 29, 2020

CC @noahfalk

@GrabYourPitchforks
Copy link
Member

GrabYourPitchforks commented Oct 29, 2020

@stephentoub Did you intend for this PR to resolve #43989? That issue seemingly tracks a new feature request.

@stephentoub
Copy link
Member Author

stephentoub commented Oct 29, 2020

Did you intend for this PR to resolve #43989? That issue seemingly tracks a new feature request.

I don't see any new feature request in the comments from the dev who opened the issue?
#43989 (comment)

What feature?

@GrabYourPitchforks
Copy link
Member

GrabYourPitchforks commented Oct 29, 2020

Ah, I misinterpreted that issue as a "please allow me to provide my own backing array to List<T>." Carry on! :)

@stephentoub
Copy link
Member Author

stephentoub commented Oct 29, 2020

😄

@runfoapp runfoapp bot mentioned this pull request Oct 29, 2020
Closed
@stephentoub stephentoub merged commit 0283591 into dotnet:master Oct 29, 2020
@stephentoub stephentoub deleted the eventsourcealloc branch October 29, 2020 23:54
@runfoapp runfoapp bot mentioned this pull request Oct 30, 2020
Open
@ghost ghost locked as resolved and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tarekgh tarekgh tarekgh approved these changes

Assignees

No one assigned

Labels

area-System.Diagnostics.Tracing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reduce List<object> allocations by passing the initial array

4 participants

@stephentoub @tarekgh @GrabYourPitchforks @Dotnet-GitSync-Bot