Add test for exception propagation inside loader events #43910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoffeeFlux
added
area-System.Runtime
increase-code-coverage
CoffeeFlux
added a commit
to CoffeeFlux/runtime
that referenced
this pull request
Oct 27, 2020
This test uses the AssemblyResolve handler, but it's arguably a reflection test at the core, so I've put it here. Happy to move it elsewhere as appropriate. It currently passes on Mono due to dotnet#43910 but should not, so I've disabled it for now. Once that issue is resolved, I'll push a fix for this and re-enable the test.
lambdageek
reviewed
Oct 27, 2020
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs
Outdated
Show resolved
Hide resolved
lambdageek
reviewed
Oct 27, 2020
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs
Outdated
Show resolved
Hide resolved
lambdageek
reviewed
Oct 27, 2020
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs
Outdated
Show resolved
Hide resolved
|
Tagging subscribers to this area: @vitek-karas, @agocke |
CoffeeFlux
force-pushed
the
exception-event-test
branch
from
985f1a8 to
ac08aa3
Compare
Contributor
Author
|
This one seems to finally be working as expected. |
Contributor
Author
|
Still need an approval on this. cc: @vitek-karas |
vitek-karas
reviewed
Nov 3, 2020
Member
vitek-karas
left a comment
vitek-karas
left a comment
There was a problem hiding this comment.
@LakshanF can you please also take a look - you've added a similar test recently.
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs
Outdated
Show resolved
Hide resolved
CoffeeFlux
force-pushed
the
exception-event-test
branch
from
ad82cd3 to
27d327a
Compare
Contributor
Author
|
Rebased and took out RemoteExecutor. Hopefully I didn't break something. |
Member
|
Looks to me as a good approach... will take another look once the tests passing. |
CoffeeFlux
force-pushed
the
exception-event-test
branch
from
4d7e42d to
737c873
Compare
vitek-karas
approved these changes
Nov 30, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently broken on Mono, see #43909