Change Task.FromResult to use same task cache as async methods #43894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
added
area-System.Threading.Tasks
breaking-change
|
Tagging subscribers to this area: @tarekgh |
ghost
added
the
needs-breaking-change-doc-created
stephentoub
commented
Oct 27, 2020
...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncTaskMethodBuilderT.cs
Outdated
Show resolved
Hide resolved
EgorBo
reviewed
Oct 27, 2020
src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 27, 2020
src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/TaskCache.cs
Outdated
Show resolved
Hide resolved
EgorBo
reviewed
Oct 27, 2020
src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs
Outdated
Show resolved
Hide resolved
MihaZupan
reviewed
Oct 27, 2020
marek-safar
reviewed
Oct 27, 2020
src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs
Outdated
Show resolved
Hide resolved
stephentoub
force-pushed
the
cachedtaskfromresult
branch
from
28cc7cb to
a0f67cd
Compare
jkotas
reviewed
Oct 27, 2020
src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Oct 27, 2020
Task.FromResult today always creates a new task. This leads developers that are aware of this to then create their own caches for common values, typically 0, true, and false, to avoid task allocations for those common values. But we already have such values cached internally, used for async method return values. We can just use the same cache for Task.FromResult.
stephentoub
force-pushed
the
cachedtaskfromresult
branch
from
7f7991c to
bbf329d
Compare
ghost
locked as resolved and limited conversation to collaborators
Member
Author
stephentoub
removed
the
needs-breaking-change-doc-created
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task.FromResult today always creates a new task. This leads developers that are aware of this to then create their own caches for common values, typically 0, true, and false, to avoid task allocations for those common values. But we already have such values cached internally, used for async method return values. We can just use the same cache for Task.FromResult.
Fixes #22627