Set default value for value-type ctor params properly#43831
Merged
layomia merged 2 commits intodotnet:masterfrom Oct 30, 2020
Merged
Set default value for value-type ctor params properly#43831layomia merged 2 commits intodotnet:masterfrom
layomia merged 2 commits intodotnet:masterfrom
Conversation
ahsonkhan
reviewed
Oct 27, 2020
.../System.Text.Json/tests/Serialization/ConstructorTests/ConstructorTests.ParameterMatching.cs
Outdated
Show resolved
Hide resolved
steveharter
approved these changes
Oct 30, 2020
Member
|
Issue has come up again, should this be backported? #45221 |
layomia
added a commit
to layomia/dotnet_runtime
that referenced
this pull request
Dec 2, 2020
* Set default value for value-type ctor params properly * Address review feedback
layomia
added a commit
that referenced
this pull request
Dec 8, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43757.