(MQ cleanup) Use BinaryPrimitives where possible #43474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This seems like something that could be automated to catch the majority of cases. Did you consider an analyzer/fixer? |
Member
Author
Only briefly. The big marks against spending time working on an analyzer are that: (a) there didn't seem to be an egregiously large number of occurrences; and (b) even within this PR there were a few different variations on this pattern. |
stephentoub
reviewed
Oct 21, 2020
src/libraries/Common/src/System/Net/SocketAddressPal.Windows.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 21, 2020
| buffer[5] = (byte)0; | ||
| buffer[6] = (byte)0; | ||
| buffer[7] = (byte)0; | ||
| BinaryPrimitives.WriteUInt32LittleEndian(buffer.AsSpan(4), 0); |
Member
There was a problem hiding this comment.
Endianness here wouldn't matter. But I guess it doesn't really matter perf-wise, especially on a little-endian arch.
stephentoub
reviewed
Oct 21, 2020
stephentoub
reviewed
Oct 21, 2020
src/libraries/System.Private.CoreLib/src/System/Resources/ResourceReader.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 21, 2020
Member
Author
|
Oh, the joys of not having a working build environment and relying on CI. ;) |
Member
Author
|
Failing OSX leg is known issue #44037. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finds places in the code where we're reading data one byte at a time to build up a larger integer, and it replaces those patterns with calls to
BinaryPrimitivesinstead.Since
BinaryPrimitiveswasn't introduced until netcoreapp2.1, I didn't touch projects like System.Diagnostics.EventLog that target earlier runtimes. I also didn't touch existing netcoreapp2.1 projects if it would have meant adding a System.Memory package dependency where such direct dependency didn't previously exist. I also didn't touch the wasm-specific crypto code which was essentially a direct port from .NET Framework 4.x. That code's being deleted eventually anyway.Risks:
BigEndianwhere I meant to writeLittleEndian(or vice versa).MemoryExtensions.Slice.NullReferenceExceptionor anIndexOutOfRangeException. The new code paths instead will result in anArgumentOutOfRangeException. I don't think anybody is relying on the old behavior because I believe every call site I touched is guarded with an explicit bounds check, but needs to be called out nonetheless.