Replace ReusableTextReader with shared ArrayPool #43365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @jkotas, @danmosemsft |
stephentoub
reviewed
Oct 13, 2020
src/libraries/Common/src/Interop/Linux/procfs/Interop.ProcFsStat.TryReadStatusFile.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 13, 2020
src/libraries/Common/src/Interop/Linux/procfs/Interop.ProcFsStat.TryReadStatusFile.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 13, 2020
src/libraries/Common/src/Interop/Linux/procfs/Interop.ProcFsStat.TryReadStatusFile.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 13, 2020
src/libraries/Common/src/Interop/Linux/procfs/Interop.ProcFsStat.TryReadStatusFile.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 13, 2020
src/libraries/Common/src/Interop/Linux/procfs/Interop.ProcFsStat.TryReadStatusFile.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 13, 2020
src/libraries/Common/src/Interop/Linux/procfs/Interop.ProcFsStat.TryReadStatusFile.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 13, 2020
src/libraries/Common/src/Interop/Linux/procfs/Interop.ProcFsStat.TryReadStatusFile.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 13, 2020
src/libraries/Common/src/Interop/Linux/procfs/Interop.ProcFsStat.TryReadStatusFile.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Oct 13, 2020
src/libraries/Common/src/Interop/Linux/procfs/Interop.ProcFsStat.TryReadStatusFile.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Oct 13, 2020
jkotas
reviewed
Oct 13, 2020
src/libraries/Common/src/Interop/Linux/procfs/Interop.ProcFsStat.TryReadStatusFile.cs
Outdated
Show resolved
Hide resolved
danmoseley
reviewed
Oct 14, 2020
| } | ||
| finally | ||
| { | ||
| ArrayPool<byte>.Shared.Return(bytes); |
Member
There was a problem hiding this comment.
@jkotas I have seen in some cases we don't bother to return in exceptional cases. Yet, I could imagine for some OS reason, we are always failing to read this file, and we are called often, so we drain the array pool. I guess it depends on the context?
Member
There was a problem hiding this comment.
Yep, it depends on the context. I think the try/finally is appropriate here.
danmoseley
approved these changes
Oct 14, 2020
Member
|
failure is #43200 |
Member
|
thanks @am11 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReusableTextReaderis only used internally on Linux and it allocates buffers in the ctor. Instantiating it in a static context makes the CoreLib linker unfriendly. This change replaces the usage of RTR withArrayPool<T>, and deletes the class.Fixes #43337