Skip to content

Simple GT_NEG optimization for #13837 #43148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JulieLeeMSFT wants to merge 3 commits into from
Closed

Simple GT_NEG optimization for #13837 #43148

JulieLeeMSFT wants to merge 3 commits into from

Conversation

@JulieLeeMSFT
Copy link
Member

@JulieLeeMSFT JulieLeeMSFT commented Oct 7, 2020

Fixes #13837

@JulieLeeMSFT JulieLeeMSFT added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 7, 2020
@JulieLeeMSFT JulieLeeMSFT added this to the 6.0.0 milestone Oct 7, 2020
@JulieLeeMSFT JulieLeeMSFT self-assigned this Oct 7, 2020
@dnfadmin
Copy link

dnfadmin commented Oct 7, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@AndyAyersMS
Copy link
Member

AndyAyersMS commented Oct 27, 2020

@JulieLeeMSFT there are some test failures here, eg

;; JIT\Regression\JitBlue\DevDiv_545500

Assertion failed 'vnWx != NoVN' in 'DevDiv_545500:Test(float,int,long):ubyte' 
   during 'Optimize Valnum CSEs' (IL size 174)

Also it's customary to either run jit-diff to show this pattern is firing in code that we regularly test and/or add new test cases.

@EgorBo
Copy link
Member

EgorBo commented Oct 27, 2020

I guess !optValnumCSE_phase should help or maybe
SetOper(oper) -> SetOper(oper, GenTree::PRESERVE_VN) since SetOper clears VN by default.

@JulieLeeMSFT JulieLeeMSFT mentioned this pull request Oct 27, 2020
Merged
@JulieLeeMSFT
Copy link
Member Author

JulieLeeMSFT commented Oct 27, 2020

Replaced by #43921

@JulieLeeMSFT
Copy link
Member Author

JulieLeeMSFT commented Oct 27, 2020

@JulieLeeMSFT there are some test failures here, eg

;; JIT\Regression\JitBlue\DevDiv_545500

Assertion failed 'vnWx != NoVN' in 'DevDiv_545500:Test(float,int,long):ubyte' 
   during 'Optimize Valnum CSEs' (IL size 174)

Also it's customary to either run jit-diff to show this pattern is firing in code that we regularly test and/or add new test cases.

Will check if there still exists assertion with the fix in #43921.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
@JulieLeeMSFT JulieLeeMSFT deleted the 13837 branch August 14, 2021 03:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@JulieLeeMSFT JulieLeeMSFT

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

JIT: Optimize simple arithmetic with GT_NEG

5 participants

@JulieLeeMSFT @dnfadmin @AndyAyersMS @EgorBo @ewhapdx