Collect GetRandomBytes perf numbers #42777
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
added
NO-REVIEW
Member
Author
|
Collect performance numbers for #42770 |
stephentoub
reviewed
Sep 26, 2020
| { | ||
| Stopwatch sw = new Stopwatch(); | ||
| Guid g = new Guid(); | ||
| for (;;) |
Member
There was a problem hiding this comment.
Was this intentional? (I realize the PR is "no review", but I had to look... and I'm not sure how much log output you'll get if the whole thing times out... maybe it'll be ok)
Member
Author
There was a problem hiding this comment.
I believe that the log is still collected, even when things timeout.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.