Remove the directory src/coreclr/tests/src #42139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trylek
force-pushed
the
ExecutionScripts
branch
from
4bc7420 to
abff90c
Compare
trylek
force-pushed
the
ExecutionScripts
branch
from
abff90c to
085183c
Compare
trylek
changed the title
Member
Author
|
Seems to be finally working now... /cc @dotnet/runtime-infrastructure |
ViktorHofer
approved these changes
Sep 14, 2020
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
LGTM assuming the outerloop failures are unrelated?
Member
Author
|
I believe the outerloop failure in the Alpine run is expected, adding @janvorli to confirm. |
Member
Author
|
Confirmed with Jan, he's already sent out the PR for the fix (#42195). I suspect we'll need to add a WASM-specific exclusion for the UnmanagedCallersOnlyTest to issues.targets, apparently after Aaron's recent refactoring the test is no longer compatible with the WASM platform, FYI /cc @naricc, @SamMonoRT and @directhex. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move CLRTest.*.targets under src/tests/Common;
Consolidate Directory.Build.props in src/tests, src/tests/Common and src/coreclr/tests/src - src/tests is now the "master" version, src/tests/Common just points to it and src/coreclr/tests/src no longer exists;
Move Directory.Build.targets from src/coreclr/tests/src to src/tests/Directory.Build.targets that was previously just importing the src/coreclr/tests/src version;
Move the few remaining scripts under src/coreclr/tests/src to src/tests/Common (dirs.proj, nobuild.targets, runonly.targets, xunitconsolerunner.depproj).
Thanks
Tomas