Skip to content

Revert #40641 #41817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carlossanlop merged 1 commit into from
Sep 4, 2020
Merged

Revert #40641 #41817

carlossanlop merged 1 commit into from
Sep 4, 2020

Conversation

@carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Sep 3, 2020

Fixes #41739

Reverts PR #40641 - "Ensure FileStatus and FileSystemEntry Hidden and ReadOnly attributes are retrieved the same way" which introduced a perf regression on Unix in Directory.EnumerateFiles.

@carlossanlop
Revert #40641
8feee81 
Reverts "Ensure FileStatus and FileSystemEntry Hidden and ReadOnly attributes are retrieved the same way"
(commit 6ed1e41) which introduced a perf regression.
@carlossanlop carlossanlop self-assigned this Sep 3, 2020
@carlossanlop
Copy link
Contributor Author

carlossanlop commented Sep 3, 2020

/backport to release/5.0-rc2

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2020

Started backporting to release/5.0-rc2: https://github.com/dotnet/runtime/actions/runs/238165020

@github-actions github-actions bot mentioned this pull request Sep 3, 2020
Merged
@carlossanlop
Copy link
Contributor Author

carlossanlop commented Sep 3, 2020

Is this revert in master necessary? Can we work on addressing the perf regression on top of this, without having to remove the commit?

@jeffhandley
Copy link
Member

jeffhandley commented Sep 3, 2020

I have a slight preference to make the revert and get to a good baseline before attempting the fix again, but I defer to you and @adamsitnik for your recommendation.

@jeffhandley jeffhandley mentioned this pull request Sep 3, 2020
Merged
@carlossanlop
Copy link
Contributor Author

carlossanlop commented Sep 4, 2020

Ok no problem @jeffhandley. I can get it in a new PR, with the fix.

@carlossanlop carlossanlop merged commit 1d17ce6 into dotnet:master Sep 4, 2020
@carlossanlop carlossanlop deleted the revert branch September 4, 2020 00:40
@jeffhandley
Copy link
Member

jeffhandley commented Sep 4, 2020

Sounds good, @carlossanlop; thanks. And there's no urgency on it now--we can just reopen the original issue into the 6.0.0 milestone and have it in the backlog.

@adamsitnik
Copy link
Member

adamsitnik commented Sep 4, 2020

I can get it in a new PR, with the fix.

sounds good to me 👍

@adamsitnik adamsitnik added this to the 5.0.0 milestone Sep 4, 2020
@adamsitnik adamsitnik added the tenet-performance Performance related issue label Sep 4, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeffhandley jeffhandley jeffhandley approved these changes

@stephentoub stephentoub Awaiting requested review from stephentoub

@danmoseley danmoseley Awaiting requested review from danmoseley

@jozkee jozkee Awaiting requested review from jozkee

Assignees

@carlossanlop carlossanlop

Labels

area-System.IO tenet-performance Performance related issue

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[Unix] Potential performance regression in Directory.EnumerateFiles

4 participants

@carlossanlop @jeffhandley @adamsitnik @Dotnet-GitSync-Bot