Add HTTP Request/Response Headers/Content Start/Stop events #41590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
Member
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ManickaP
reviewed
Aug 31, 2020
Member
ManickaP
left a comment
ManickaP
left a comment
There was a problem hiding this comment.
In Request(Start/Stop) we are guarding against dangling Stop events with telemetryStarted booleans. Also Stops are called in finally blocks so the events are paired properly in all cases.
Any reason we forgo this with these events?
Member
Author
|
RequestStart/Stop are also updating the internal request started/aborted/finished numbers used by Counters. The extra logic around them is to ensure counters are reporting correct values. |
MihaZupan
added a commit
to MihaZupan/runtime
that referenced
this pull request
Aug 31, 2020
MihaZupan
added a commit
that referenced
this pull request
Aug 31, 2020
* System.Net Telemetry style changes (#41527) * Change HandshakeStop SslProtocols parameter to enum * Parameterize Http11/Http20 events * Add dummy request to ensure Http2 settings are received * Moved HTTP request telemetry to HttpClient.SendAsync (#41022) * Moved HTTP request telemetry to HttpClient.SendAsync * Added ResponseContent and helper methods events. * Rework helper method activity nesting * Expand Telemetry tests * Also log RequestStart/Stop in HttpMessageInvoker * Update RequestStart signature * RequestAborted => RequestFailed rename * ResponseContent Begin => Start/Stop * Fix HttpMessageInvoker implementation * Add Synchronous request Telemetry tests * Check telemetryStarted before ResponseContentStart Co-authored-by: MihaZupan <[email protected]> * Add Request/Response Headers/Content Start/Stop events (#41590) Co-authored-by: Marie Píchová <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResponseHeadersBeginRequestHeadersStart,RequestHeadersStopRequestContentStart,RequestContentStop(long contentLength)ResponseHeadersStart,ResponseHeadersStop