update product version to 6.0.0 #40950
Conversation
|
Tagging subscribers to this area: @safern, @ViktorHofer |
|
Can you double check every project that
And add a |
There was a problem hiding this comment.
I thought we had plumbed the correct data for this through the header?
There was a problem hiding this comment.
we missed the hex strings
There was a problem hiding this comment.
i will hardcode for this pr and fix after the snap
Per offline conversation, this doesn't need to be done with the version change, but does need to happen when the TFM changes. The TFM change can be separate as it likely requires a bit more to make the SDK work with the new TFM. (EG: temporary KnownFrameworkReference) |
There was a problem hiding this comment.
Technically we should be setting baselineVersion for all packages. However it's likely less important here since we don't ever use PackageReferences to the Microsoft.Extensions packages and none of their versions are frozen (so all assembly refs will be to 6.0.0.0 and thus get the 6.0.0-* packages).
eng/targetingpacks.targets
Outdated
There was a problem hiding this comment.
I think we still want to download the targeting pack if UseLocalTargetingRuntimePack=false. It's possible that the SDK doesn't carry it (once it moves to net6.0 for example).
...aries/Microsoft.XmlSerializer.Generator/tests/Microsoft.XmlSerializer.Generator.Tests.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This deserves a comment. Let's mention that this test assembly needs to run on the tool shared framework so it should reference the latest references. We build against tool shared framework's ref pack, run the generator on the tool shared framework, then execute the test on the test shared framework.
...aries/Microsoft.XmlSerializer.Generator/tests/Microsoft.XmlSerializer.Generator.Tests.csproj
Outdated
Show resolved
Hide resolved
eng/packaging.props
Outdated
There was a problem hiding this comment.
Not for this PR, but we should try to make this use $(ProductVersion) if possible.
ghost
locked as resolved and limited conversation to collaborators
7 participants
Uh oh!
There was an error while loading. Please reload this page.