Skip to content

Minimum CMake downgrade for Linux (#39044)#40471

Merged
mmitche merged 1 commit intodotnet:release/5.0-preview8from
jashook:port_39044
Aug 7, 2020
Merged

Minimum CMake downgrade for Linux (#39044)#40471
mmitche merged 1 commit intodotnet:release/5.0-preview8from
jashook:port_39044

Conversation

@jashook
Copy link
Contributor

@jashook jashook commented Aug 6, 2020

Port Minimum CMake downgrade for Linux back to preview 8. This addresses #38755 and unblocks source-build in preview 8 using cmake < 3.15.

/cc @jkoritzinsky @janvorli @jeffschwMSFT @mmitche

@jkoritzinsky @safern @janvorli
Minimum CMake downgrade for Linux (dotnet#39044)
0aadb20 
Co-authored-by: Santiago Fernandez Madero <[email protected]>
Co-authored-by: Jan Vorlicek <[email protected]>
@jashook
Copy link
Contributor Author

jashook commented Aug 6, 2020 •
edited
Loading

Similar to the master branch I will validate that the build works and a run pri0 tests. Will update with results.

Clean builds with the following:

Os Cmake Clang/llvm
Centos 7 3.6.2 7
Centos 8 3.11.4 8

I have run Pri0 tests on both platforms. The following tests fail:

/runtime/artifacts/tests/coreclr/Linux.x64.Checked/Loader/binding/tracing/BinderTracingTest.ResolutionFlow/BinderTracingTest.ResolutionFlow.sh (30 seconds)
/runtime/artifacts/tests/coreclr/Linux.x64.Checked/Loader/binding/tracing/BinderTracingTest.Basic/BinderTracingTest.Basic.sh (30 seconds)
/runtime/artifacts/tests/coreclr/Linux.x64.Checked/profiler/unittest/getappdomainstaticaddress/getappdomainstaticaddress.sh (2 seconds)
/runtime/artifacts/tests/coreclr/Linux.x64.Checked/tracing/eventpipe/eventsourceerror/eventsourceerror/eventsourceerror.sh (1 seconds)

@jashook
Copy link
Contributor Author

jashook commented Aug 7, 2020

Manually validated the build on centos7 and centos8.

@mmitche
Copy link
Member

mmitche commented Aug 7, 2020

@jashook Any concern with the OSX failure? I've retried it a ton of times.

@jashook
Copy link
Contributor Author

jashook commented Aug 7, 2020

No concern. I believe we need to port back the timeout change we made in master now that the osx machines are slower.

@mmitche mmitche merged commit bf45665 into dotnet:release/5.0-preview8 Aug 7, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

Assignees

No one assigned

Labels

area-Infrastructure-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jashook @mmitche @jkoritzinsky @jeffschwMSFT @Dotnet-GitSync-Bot