WASM: Add an internal method to pump the threadpool #38690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
requested review from
CoffeeFlux,
EgorBo,
SamMonoRT,
alexischr,
lambdageek,
marek-safar and
steveisok
as code owners
stephentoub
approved these changes
Jul 1, 2020
src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs
Outdated
Show resolved
Hide resolved
CoffeeFlux
reviewed
Jul 2, 2020
src/mono/netcore/System.Private.CoreLib/src/System/Threading/ThreadPool.Browser.Mono.cs
Show resolved
Hide resolved
marek-safar
approved these changes
Jul 2, 2020
akoeplinger
added a commit
to akoeplinger/xharness
that referenced
this pull request
Jul 2, 2020
premun
pushed a commit
to dotnet/xharness
that referenced
this pull request
Jul 2, 2020
6 tasks
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can by used by the xharness xunit runner to make sure async tasks are executed.
We also need to tweak how
ThreadPoolTaskSchedulerhandlesTaskCreationOptions.LongRunningsince the usual mode of starting a new thread doesn't work, instead we treat it like the option wasn't set and queue the task on the threadpool.