Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

CC. @echesakovMSFT, @CarolEidt for review.

CC. @EgorBo, this seems to have broken Mono, is there something specific I need to update?

@tannergooding looks like it's a different issue, so should be OK from mono side.

Alright, it looked to be a failure in the test this PR is adding, so I wasn't sure. Thanks!

@EgorBo, looks like its still failing. Based on the failure, some API is returning IsSupported where a lower ISA is not. It isn't clear which API that is as there is no line information in the failure.

@tannergooding where can I find that test? I don't see any Runtime_34587 test in the sources, is it internal?

Right here: https://github.com/dotnet/runtime/pull/38460/files#diff-e4e58d0c6a832040d081a159b95e83bb

It just validates that for any IsSupported == true, the relevant related conditions are met.

Right here: https://github.com/dotnet/runtime/pull/38460/files#diff-e4e58d0c6a832040d081a159b95e83bb

It just validates that for any IsSupported == true, the relevant related conditions are met.

can you please add this test to issues.targets to ignore on Mono and I'll take a look tomorrow.
it looks like our hierarchy is a bit outdated e.g. we don't support X86Base

This was JIT/EE interface breaking change and it should have updated the JIT/EE interface GUID.

I am adding a note about it in #39777