Fix Diagnostics.Tracing ILLinkTrim entries #38125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix PropertyValue/ReferenceTypeHelper with a DynamicDependency - RuntimeEventSource doesn't need to be rooted. This class is used by IL and doesn't get trimmed. - EventPipe* and NativeRuntimeEventSource only need to be rooted in CoreCLR, since they aren't used in Mono. So they are moved to just CoreCLR's ILLinkTrim file. Contributes to dotnet#35199
Member
|
CC @noahfalk |
joperezr
reviewed
Jun 18, 2020
src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.Shared.xml
Show resolved
Hide resolved
joperezr
approved these changes
Jun 18, 2020
…es this pattern, and the attribute isn't available outside of net5.0 TFM.
marek-safar
approved these changes
Jun 19, 2020
Member
|
cc @dotnet/dotnet-diag |
sywhang
approved these changes
Jun 19, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #35199
cc @marek-safar