Add System.Runtime.CompilerServices.IsExternalInit#37763
Add System.Runtime.CompilerServices.IsExternalInit#37763jkotas merged 2 commits intodotnet:masterfrom
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Co-authored-by: Jan Kotas <[email protected]>
| /// This class should not be used by developers in source code. | ||
| /// </summary> | ||
| [EditorBrowsable(EditorBrowsableState.Never)] | ||
| public static class IsExternalInit |
There was a problem hiding this comment.
I just want to clarify... the issue lists the type as sealed:
#34978 (comment)
but here it's static. static rather than sealed was actually intended?
There was a problem hiding this comment.
Yes, after closer examination of other types used by the compiler in modreqs, we decided this should be a static class similar to IsVolatile
|
@stephentoub is this ready for merge or is further review needed? |
|
Ping @jaredpar |
ghost
locked as resolved and limited conversation to collaborators
4 participants
Resolves #34978
The up to date description on how we want to do this is here: #34978 (comment)
Looking at some of the other compiler-known attributes used in modreqs, it seems like the class should be 'static' as well.
I think there is no boilerplate unit test to add for this one because the static class doesn't contain any members.