Kill REG_PROFILER_RET_SCRATCH#37679
Merged
CarolEidt merged 1 commit intodotnet:masterfrom Jun 12, 2020
Merged
Conversation
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
Contributor
Author
|
@dotnet/jit-contrib PTAL |
Contributor
Author
|
ping @dotnet/jit-contrib |
echesakov
reviewed
Jun 11, 2020
Contributor
echesakov
left a comment
echesakov
left a comment
There was a problem hiding this comment.
@CarolEidt I have a question - what would happen when r0 is not used (when a method returns void, HFA, or uses a return buffer)? We will still consider r2 (REG_PROFILER_RET_SCRATCH) as killed even though it wasn't?
BruceForstall
approved these changes
Jun 11, 2020
Contributor
Author
Yes, unfortunately that's the case. |
This was referenced Jul 1, 2020
AndyAyersMS
added a commit
to AndyAyersMS/runtime
that referenced
this pull request
Jul 1, 2020
This reverts commit b179e19.
AndyAyersMS
added a commit
to AndyAyersMS/runtime
that referenced
this pull request
Jul 15, 2020
This reverts commit b179e19.
AndyAyersMS
added a commit
that referenced
this pull request
Jul 17, 2020
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
This reverts commit b179e19.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If profiling is enabled, we need to kill
REG_PROFILER_RET_SCRATCHas it may be used if r0 is occupied.Fix #37223