MulticastOption.Group no longer accepts null. #32518
Conversation
eerhardt
added
the
breaking-change
@ericstj knows where breaking changes should be mentioned. For dotnet-api-docs, I can help. |
There was a problem hiding this comment.
Since this API did not have triple slash comments, and is already documented in MS Docs, this new exception must be added here:
src/libraries/System.Net.Sockets/src/System/Net/Sockets/UdpReceiveResult.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Sockets/tests/FunctionalTests/MulticastOptionTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Sockets/src/System/Net/Sockets/MulticastOption.cs
Outdated
Show resolved
Hide resolved
MulticastOption.Group is not supposed to accept null. If someone sets it to null, we will NRE inside of the Sockets implementation. I also fixed two small double-cast problems while I was in here. Fix dotnet#32490
|
@eerhardt this is labeled breaking change. Can you please open an issue if necessary using https://github.com/dotnet/docs/issues/new?template=dotnet-breaking-change.md ? |
Done. dotnet/docs#19723 |
ghost
locked as resolved and limited conversation to collaborators
5 participants
MulticastOption.Group is not supposed to accept null. If someone sets it to null, we will NRE inside of the Sockets implementation.
I also fixed two small double-cast problems while I was in here.
Fix #32490
Note that this is a breaking change. I'm not sure all the ways I'm supposed to document this. If anyone has thoughts, please let me know.