-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Use 3 argument Array.Copy, as it is more optimized in .NET5 #32387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ImmutableArray tests are failing: |
|
It should be fine to fix the test failures by relaxing the argument name validation in this test. |
|
@jkotas Do you mean something like: // Skip checking .NETFramework parameter name is either 'destinationArray' or 'dest'
AssertExtensions.Throws<ArgumentNullException>("destinationArray", netFxParamName: null, () => array.CopyTo(null));
AssertExtensions.Throws<ArgumentNullException>("destinationArray", netFxParamName: null, () => array.CopyTo(null, 0));
AssertExtensions.Throws<ArgumentNullException>("destinationArray", netFxParamName: null, () => array.CopyTo(0, null, 0, 0));
AssertExtensions.Throws<ArgumentNullException>("destinationArray", netFxParamName: null, () => array.CopyTo(-1, null, -1, -1)); // The destination should be validated first. |
ed38590 to
b15b6dc
Compare
src/libraries/System.Collections.Immutable/tests/ImmutableArrayTest.cs
Outdated
Show resolved
Hide resolved
f91ebde to
d21ef83
Compare
|
@Therzok, still working on this? |
|
@stephentoub I'll setup the repo on a Windows machine to see why it's failing, the tests passed locally on OS X. Sorry for the delays. |
|
If you need help, let me know (and if I have push permissions to your branch, I can just fix it for you, too). |
|
I've had a few hoops and hurdles. If you have MSBuild Build Tools installed and they don';t have the required pre-reqs, you could end up opening the wrong developer command prompt to build. I'm trying to get the in-VS tests to run right now, looking at the test explorer, it doesn't seem to run them. Although it seems the top menu run seems to work. |
|
Okay, so, I've managed to get it setup and run it on .netcore. Whenever I try to run the .NET Framework config, I'm getting |
5e4e676 to
54c50c2
Compare
|
I fixed up the commit. Thanks for the contribution. |
|
Thanks for that! |
No description provided.