Skip to content

Conversation

@Therzok
Copy link
Contributor

@Therzok Therzok commented Feb 16, 2020

No description provided.

@jkotas
Copy link
Member

jkotas commented Feb 16, 2020

ImmutableArray tests are failing:

    System.Collections.Immutable.Tests.ImmutableArrayTest.CopyToInvalid(source: []) [FAIL]
      Assert.Equal() Failure
                    � (pos 4)
      Expected: dest
      Actual:   destinationArray
                    � (pos 4)
      Stack Trace:
        /_/src/libraries/Common/tests/CoreFx.Private.TestUtilities/System/AssertExtensions.cs(46,0): at System.AssertExtensions.Throws[T](String netCoreParamName, String netFxParamName, Action action)
        /_/src/libraries/System.Collections.Immutable/tests/ImmutableArrayTest.cs(1635,0): at System.Collections.Immutable.Tests.ImmutableArrayTest.CopyToInvalid(IEnumerable`1 source)
    System.Collections.Immutable.Tests.ImmutableArrayTest.CopyToInvalid(source: [1]) [FAIL]

@jkotas
Copy link
Member

jkotas commented Feb 16, 2020

It should be fine to fix the test failures by relaxing the argument name validation in this test.

@Therzok
Copy link
Contributor Author

Therzok commented Feb 16, 2020

@jkotas Do you mean something like:

// Skip checking .NETFramework parameter name is either 'destinationArray' or 'dest'
AssertExtensions.Throws<ArgumentNullException>("destinationArray", netFxParamName: null, () => array.CopyTo(null));
AssertExtensions.Throws<ArgumentNullException>("destinationArray", netFxParamName: null, () => array.CopyTo(null, 0));
AssertExtensions.Throws<ArgumentNullException>("destinationArray", netFxParamName: null, () => array.CopyTo(0, null, 0, 0));
AssertExtensions.Throws<ArgumentNullException>("destinationArray", netFxParamName: null, () => array.CopyTo(-1, null, -1, -1)); // The destination should be validated first.

@Therzok Therzok force-pushed the immutable-array-arraycopy branch from ed38590 to b15b6dc Compare February 16, 2020 09:27
@Therzok Therzok force-pushed the immutable-array-arraycopy branch 2 times, most recently from f91ebde to d21ef83 Compare February 16, 2020 13:00
@stephentoub
Copy link
Member

@Therzok, still working on this?

@Therzok
Copy link
Contributor Author

Therzok commented Mar 13, 2020

@stephentoub I'll setup the repo on a Windows machine to see why it's failing, the tests passed locally on OS X. Sorry for the delays.

@stephentoub
Copy link
Member

If you need help, let me know (and if I have push permissions to your branch, I can just fix it for you, too).

@Therzok
Copy link
Contributor Author

Therzok commented Mar 21, 2020

I've had a few hoops and hurdles. If you have MSBuild Build Tools installed and they don';t have the required pre-reqs, you could end up opening the wrong developer command prompt to build. I'm trying to get the in-VS tests to run right now, looking at the test explorer, it doesn't seem to run them. Although it seems the top menu run seems to work.

@Therzok
Copy link
Contributor Author

Therzok commented Apr 3, 2020

Okay, so, I've managed to get it setup and run it on .netcore. Whenever I try to run the .NET Framework config, I'm getting Illegal characters in path., with no extra explanation from VS.

@stephentoub stephentoub force-pushed the immutable-array-arraycopy branch from 5e4e676 to 54c50c2 Compare April 12, 2020 23:26
@stephentoub stephentoub merged commit f0ede00 into dotnet:master Apr 13, 2020
@stephentoub
Copy link
Member

I fixed up the commit. Thanks for the contribution.

@Therzok
Copy link
Contributor Author

Therzok commented Apr 13, 2020

Thanks for that!

@Therzok Therzok deleted the immutable-array-arraycopy branch April 13, 2020 16:33
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants