Skip to content

Remove CreateDefensiveCopy and inline it in ImmutableArray.Create #32386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkotas merged 1 commit into from
Feb 16, 2020
Merged

Remove CreateDefensiveCopy and inline it in ImmutableArray.Create #32386

jkotas merged 1 commit into from
Feb 16, 2020

Conversation

@Therzok
Copy link
Contributor

@Therzok Therzok commented Feb 16, 2020

No description provided.

@Therzok Therzok mentioned this pull request Feb 16, 2020
Closed
@jkotas
Copy link
Member

jkotas commented Feb 16, 2020

Build error:

System/Collections/Immutable/ImmutableArray.cs(159,24): error CS8604: Possible null reference argument for parameter 'sourceArray' in 'void Array.Copy(Array sourceArray, Array destinationArray, int length)'. [/Users/runner/runners/2.164.8/work/1/s/src/libraries/System.Collections.Immutable/src/System.Collections.Immutable.csproj]

@Therzok Therzok force-pushed the immutable-array-inline branch from 1f83e7b to 3d9fa63 Compare February 16, 2020 08:34
@jkotas jkotas merged commit 9cba68e into dotnet:master Feb 16, 2020
@Therzok Therzok deleted the immutable-array-inline branch February 16, 2020 11:41
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

@jkotas jkotas jkotas approved these changes

Assignees

No one assigned

Labels

area-System.Collections

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Therzok @jkotas @stephentoub @Dotnet-GitSync-Bot