[mono] Review [SkipOnTargetFramework(TargetFrameworkMonikers.Mono...] occurrences #31920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
requested changes
Feb 7, 2020
src/libraries/System.Data.Common/tests/System/Data/Common/DbCommandTests.cs
Outdated
Show resolved
Hide resolved
MaximLipnin
commented
Feb 7, 2020
MaximLipnin
force-pushed
the
mono_skipontargetframework
branch
from
992bcb5 to
f94c07d
Compare
jkotas
approved these changes
Feb 7, 2020
MaximLipnin
force-pushed
the
mono_skipontargetframework
branch
from
f94c07d to
9d60b92
Compare
akoeplinger
reviewed
Feb 7, 2020
|
|
||
| [Fact] | ||
| [SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "https://bugzilla.xamarin.com/show_bug.cgi?id=60568")] | ||
| public static void WaitNotificationTest() |
Member
There was a problem hiding this comment.
Looks like this test still fails. The bugzilla bug was marked as fixed so probably some other issue.
Can you please add a new issue for this and disable the test with ActiveIssue?
…cationTest with an active issue
Contributor
Author
|
Filed #31977 |
ghost
added
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to re-exam the existing tests annotated with
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono...]attribute since some of them mention old bugzilla bugs or issues in old mono/mono BCL implementation that should no longer apply.