Delete checked-in Unicode data files in favor of runtime-assets package #1743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- IDNA files (in System.Globalization.Extensions.Tests) not yet deleted
safern
reviewed
Jan 15, 2020
src/libraries/System.Text.Encodings.Web/tools/updating-encodings.md
Outdated
Show resolved
Hide resolved
safern
reviewed
Jan 15, 2020
src/libraries/System.Text.Encodings.Web/tests/System.Text.Encodings.Web.Tests.csproj
Show resolved
Hide resolved
safern
reviewed
Jan 15, 2020
src/libraries/System.Text.Encodings.Web/tests/System.Text.Encodings.Web.Tests.csproj
Show resolved
Hide resolved
stephentoub
reviewed
Jan 15, 2020
...braries/Common/tests/CoreFx.Private.TestUtilities.Unicode/System/Text/Unicode/UnicodeData.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jan 15, 2020
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
Other than the comments, LGTM.
tarekgh
approved these changes
Jan 15, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deletes most of the Unicode data files under the
Datafolder in favor of the data files present in the runtime-assets repo, which are automatically brought in as part of package restore. There are some IDNA files checked in toSystem.Globalization.Extension.Teststhat aren't yet deleted.There are no functional changes to the product from this PR. There are only test project changes.