Repository navigation
Upgrade Unicode to 18.0 - #136937
Merged
Merged
Upgrade Unicode to 18.0#136937
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
|
Azure Pipelines: Successfully started running 4 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
am11
force-pushed
the
chore/modernize-unicodegen
branch
from
November 3, 2026 21:34
de52f27 to
8dd081e
Compare
Co-authored-by: Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
This was referenced Nov 4, 2026
Closed
jkotas
reviewed
Nov 7, 2026
jkotas
reviewed
Nov 7, 2026
jkotas
reviewed
Nov 7, 2026
jkotas
reviewed
Nov 7, 2026
jkotas
reviewed
Nov 7, 2026
jkotas
reviewed
Nov 7, 2026
jkotas
reviewed
Nov 7, 2026
jkotas
reviewed
Nov 7, 2026
jkotas
reviewed
Nov 7, 2026
am11
force-pushed
the
chore/modernize-unicodegen
branch
from
November 7, 2026 16:26
5e44a17 to
a37cbd5
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The seven new casing pairs lack active IgnoreCase tests in both directions across regex engines, and the exhaustive Unicode casing test is disabled.
1 open issue
What changed in this PR
Updates the runtime’s shared Unicode data dependency to 18.0 and refreshes encoding, regex casing, and native casing tables. Regex named blocks remain unchanged because there are no new BMP blocks.
Changes:
- Centralizes the Unicode version in
eng/Versions.propsand updates the Unicode data package. - Refreshes generated tables and marks Unicode-generated files for GitHub’s diff display.
- Repairs generator projects, converts the minipal generator to a file-based app, and updates maintenance instructions.
| File | Description |
|---|---|
| THIRD-PARTY-NOTICES.TXT | Updates the Unicode copyright year. |
| src/native/minipal/UnicodeDataGenerator/UnicodeDataGenerator.csproj | Removes the project replaced by the file-based app. |
| src/native/minipal/UnicodeDataGenerator/Program.cs | Removes the former generator entry point. |
| src/native/minipal/UnicodeDataGenerator.cs | Adds the file-based native casing generator. |
| src/native/minipal/unicodedata.c | Adds Unicode casing mappings. |
| src/libraries/System.Text.RegularExpressions/tools/Readme.md | Removes duplicated Unicode version tracking. |
| src/libraries/System.Text.RegularExpressions/tools/GenRegexNamedBlocks/README.md | Removes the hardcoded current-version statement. |
| src/libraries/System.Text.RegularExpressions/tools/GenerateRegexCasingTable.csproj | Excludes the nested named-block generator sources. |
| src/libraries/System.Text.RegularExpressions/tools/DataTable.cs | Fixes a generated comment’s formatting. |
| src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Symbolic/UnicodeCategoryRangesGenerator.cs | Removes runtime-version information from generated comments. |
| src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexCaseEquivalences.Data.cs | Refreshes regex case-equivalence tables. |
| src/libraries/System.Text.Encodings.Web/tools/updating-encodings.md | Documents centralized Unicode version selection. |
| src/libraries/System.Text.Encodings.Web/tests/System.Text.Encodings.Web.Tests.csproj | Uses the shared Unicode version. |
| src/libraries/System.Text.Encodings.Web/src/System/Text/Unicode/UnicodeHelpers.generated.cs | Refreshes the defined-character bitmap. |
| src/libraries/System.Runtime/tests/System.Globalization.Tests/System.Globalization.Tests.csproj | Uses the shared Unicode version. |
| src/libraries/System.Runtime/tests/System.Globalization.Tests/NlsTests/System.Globalization.Nls.Tests.csproj | Uses the shared version for NLS tests. |
| src/libraries/System.Runtime/tests/System.Globalization.Tests/Hybrid/System.Globalization.IOS.Tests.csproj | Uses the shared version for iOS tests. |
| src/libraries/System.Runtime/tests/System.Globalization.Tests/Hybrid/AppleHybrid.Tests.csproj | Uses the shared version for Apple hybrid tests. |
| src/libraries/System.Private.CoreLib/Tools/GenUnicodeProp/Updating-Unicode-Versions.md | Updates version-setting and native-generator instructions. |
| src/libraries/System.Private.CoreLib/Tools/GenUnicodeProp/Readme.md | Points to the centralized version property. |
| src/libraries/System.Private.CoreLib/Tools/GenUnicodeProp/GenUnicodeProp.csproj | Uses the current tool framework and shared Unicode version. |
| src/libraries/Common/tests/TestUtilities.Unicode/TestUtilities.Unicode.csproj | Uses the shared Unicode version for test resources. |
| eng/Versions.props | Defines Unicode 18.0 centrally. |
| eng/Version.Details.xml | Updates the Unicode package version and source commit. |
| eng/Version.Details.props | Updates the Unicode package version property. |
| .gitattributes | Marks Unicode tables as generated files. |
Review effort: Balanced
Co-authored-by: Cursor <[email protected]>
tarekgh
reviewed
Nov 7, 2026
tarekgh
approved these changes
Nov 7, 2026
jkotas
reviewed
Nov 8, 2026
jkotas
reviewed
Nov 8, 2026
jkotas
reviewed
Nov 8, 2026
Member
|
/ba-g intermittent github networking issues |
jkotas
approved these changes
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System.Private.Runtime.UnicodeDatato12.0.0-beta.26531.1to pick up the 18.0 data ahead of [main] Update dependencies from dotnet/icu, dotnet/runtime-assets #133384.UnicodeDataGeneratorto a file-based app (similar to Replace Python CoreCLR test tooling with C# #135253) and fixesGenUnicodePropandGenerateRegexCasingTable, which no longer built.