Repository navigation
Replace Python CoreCLR test tooling with C# - #135253
Merged
Merged
Conversation
Replace the Python runtime test runner and crossgen2 comparison tool with C# file-based apps. Publish the comparison runner as a native executable for Helix. Co-authored-by: Copilot <[email protected]> Copilot-Session: f2666304-e57e-4639-a8cf-de7df0126ccc
Delete unused Python test utilities and the orphaned Smarty launcher as part of removing Python from the runtime test infrastructure. Co-authored-by: Copilot <[email protected]> Copilot-Session: f2666304-e57e-4639-a8cf-de7df0126ccc
Co-authored-by: Copilot <[email protected]> Copilot-Session: bccb474c-a460-4ca7-abae-8247ecab3b91
github-actions
Bot
added
the
area-Infrastructure-coreclr
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Oct 6, 2026
am11
reviewed
Oct 6, 2026
Co-authored-by: Adeel Mujahid <[email protected]>
davidwrighton
approved these changes
Oct 14, 2026
agocke
enabled auto-merge (squash)
October 14, 2026 22:50
This was referenced Oct 15, 2026
Closed
agocke
disabled auto-merge
October 23, 2026 04:06
Member
Author
|
/ba-g all failures known |
jkotas
pushed a commit
that referenced
this pull request
Nov 8, 2026
- Regex named blocks were already moved to Unicode 17.0 in #120623 while the rest of the repo stayed on 16.0. This upgrades the remaining Unicode data (CoreLib, System.Text.Encodings.Web, Regex case equivalences and the native minipal casing table) straight to 18.0, the version now in dotnet/runtime-assets (dotnet/runtime-assets#715). Unicode 18.0 has no BMP block changes, so the named blocks table is unchanged. - Bumps `System.Private.Runtime.UnicodeData` to `12.0.0-beta.26531.1` to pick up the 18.0 data ahead of #133384. - Converts the minipal `UnicodeDataGenerator` to a file-based app (similar to #135253) and fixes `GenUnicodeProp` and `GenerateRegexCasingTable`, which no longer built. --------- Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
./build.sh clr+libs -lc release -rc checked -clang20— passed (0 warnings, 0 errors) after raising the local WSL cgroup PID limit to 8192; earlier attempts failed whensccachecould not spawn compilers under the lower PID limit../src/tests/build.sh checked— passed (7 warnings, 0 errors)../src/tests/run.sh checked— passed: 4,364 passed, 208 skipped (including 30 ActiveIssue skips), 0 failed, 4,572 total. The wrapper invokedsrc/tests/run.cs./home/andy/code/runtime/.dotnet/dotnet run --file src/tests/run.cs -- --help— passed./home/andy/code/runtime/.dotnet/dotnet run --file src/tests/run.cs -- --tree— expected argument error (exit 2)./home/andy/code/runtime/.dotnet/dotnet run --file src/tests/Common/scripts/crossgen2_comparison.cs -- --help— passed./home/andy/code/runtime/.dotnet/dotnet publish src/tests/Common/scripts/crossgen2_comparison.cs -c Release -r linux-x64 -p:PublishAot=true -o <temporary-output-directory>— passed; the published binary's--helpalso passed.git diff --checkpassed.--helpruns measured median startup of 0.05s forpython3 run.pyand 0.07s for the C# file-based runner on this machine. This does not measure test runtime.Publishing on Windows, macOS, and other architectures remains for CI to validate.
Note
This pull request description was generated with GitHub Copilot.