Skip to content

Fix NativeAOT namespace lookup for nested generic types - #135177

Merged
jkotas merged 13 commits into
mainfrom
copilot/nativeaot-fix-null-namespace
Oct 5, 2026
Merged

Fix NativeAOT namespace lookup for nested generic types#135177
jkotas merged 13 commits into
mainfrom
copilot/nativeaot-fix-null-namespace

Conversation

Copilot AI commented Oct 4, 2026 •
edited by jkotas
Loading

Copy link
Copy Markdown
Contributor

NativeAOT returned null for Type.Namespace on nested generic types, despite their namespace-qualified FullName.

  • Metadata: Stop emitting namespace definitions for nested types and document the schema invariant.
  • Reflection: Resolve namespaces through enclosing types; exclude nested types from top-level well-known attribute matching.
  • Coverage: Add cases for nested generic definitions and constructions, global-namespace nesting, and nested attribute lookalikes.

Fixes #135106

@azure-pipelines

azure-pipelines Bot commented Oct 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI linked an issue Oct 4, 2026 that may be closed by this pull request
NativeAOT returns null Type.Namespace for a nested generic type whose FullName includes a namespace #135106
Closed
@dotnet-policy-service

dotnet-policy-service Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

Copilot AI changed the title [WIP] Fix null Type.Namespace for nested generic types in NativeAOT Fix NativeAOT namespace lookup for nested generic types Oct 4, 2026
Copilot AI requested a review from jkotas October 4, 2026 02:32
Copilot AI requested a review from jkotas October 4, 2026 03:08
Copilot AI requested a review from jkotas October 4, 2026 04:34
@jkotas

jkotas commented Oct 4, 2026

Copy link
Copy Markdown
Member

/azp run runtime-nativeaot-outerloop

@azure-pipelines

azure-pipelines Bot commented Oct 4, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

This was referenced Oct 4, 2026
Open
Open
Open
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
Closed
@jkotas

jkotas commented Oct 5, 2026

Copy link
Copy Markdown
Member

/azp run runtime-nativeaot-outerloop

@azure-pipelines

azure-pipelines Bot commented Oct 5, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@jkotas

jkotas commented Oct 5, 2026

Copy link
Copy Markdown
Member

/azp run runtime-nativeaot-outerloop

@azure-pipelines

azure-pipelines Bot commented Oct 5, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

This was referenced Oct 5, 2026
Open
Open
Closed
@jkotas

jkotas commented Oct 5, 2026

Copy link
Copy Markdown
Member

/ba-g known issue #135096

@jkotas
jkotas merged commit c31313e into main Oct 5, 2026
155 of 159 checks passed
@jkotas
jkotas deleted the copilot/nativeaot-fix-null-namespace branch October 5, 2026 06:18
@dotnet-maestro dotnet-maestro Bot mentioned this pull request Oct 6, 2026
Merged
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Oct 6, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes
@jkotas jkotas Awaiting requested review from jkotas

Assignees

@jkotas jkotas

Copilot code review Copilot

Labels

area-NativeAOT-coreclr

Projects

None yet

Milestone

12.0-preview1

Development

Successfully merging this pull request may close these issues.

NativeAOT returns null Type.Namespace for a nested generic type whose FullName includes a namespace

4 participants

@jkotas @MichalStrehovsky