Repository navigation
JIT: Preserve 64-bit bit-count value numbers - #133727
Merged
AndyAyersMS merged 2 commits intoSep 12, 2026
Merged
Conversation
Fixes dotnet#133560. Co-authored-by: Copilot <[email protected]> Copilot-Session: be30cab5-d605-4896-b07e-9758803fed4f
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
This PR preserves 64-bit value numbers when folding JIT bit-counting intrinsics and adds regression coverage.
Changes:
- Preserve
TYP_LONGconstants during folding. - Add signed and unsigned tests for
PopCount,LeadingZeroCount, andTrailingZeroCount. - Register the regression test.
File summaries
| File | Description |
|---|---|
src/tests/JIT/Regression/Regression_ro_2.csproj |
Includes the new regression test. |
src/tests/JIT/Regression/JitBlue/Runtime_133560/Runtime_133560.cs |
Adds 64-bit bit-counting regression coverage. |
src/coreclr/jit/valuenum.cpp |
Preserves 64-bit value-number types. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
Resolve the regression test layout conflict from dotnet#133591. Co-authored-by: Copilot <[email protected]> Copilot-Session: be30cab5-d605-4896-b07e-9758803fed4f
Member
Author
|
@EgorBo PTAL |
EgorBo
approved these changes
Sep 11, 2026
3 tasks
Member
Author
|
/ba-g known mono failures |
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 18, 2026
Fixes dotnet#133560. Preserve `TYP_LONG` value numbers when folding 64-bit bit-counting intrinsics, and add regression coverage for signed and unsigned `PopCount`, `LeadingZeroCount`, and `TrailingZeroCount`. Validation: - Checked all-JIT build - Targeted native x64 regression test - WASM Crossgen2 compilation of the merged regression assembly > [!NOTE] > This PR description was created by GitHub Copilot. Copilot-Session: be30cab5-d605-4896-b07e-9758803fed4f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #133560.
Preserve
TYP_LONGvalue numbers when folding 64-bit bit-counting intrinsics, and add regression coverage for signed and unsignedPopCount,LeadingZeroCount, andTrailingZeroCount.Validation:
Note
This PR description was created by GitHub Copilot.