Repository navigation
Memory leak at debugger-agent.c (dotnet version - 11.0.100-rc.1.26420.103) - #133594
Merged
lateralusX merged 1 commit intoSep 11, 2026
Merged
lateralusX merged 1 commit into
lateralusX merged 1 commit into
Conversation
samitistfobos-dev
requested review from
steveisok and
vitek-karas
as code owners
September 10, 2026 12:41
dotnet-policy-service
Bot
added
the
community-contribution
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
|
Fix for #133594 |
Contributor
|
Tagging subscribers to this area: @steveisok, @thaystg, @dotnet/dotnet-diag |
lateralusX
reviewed
Sep 10, 2026
samitistfobos-dev
force-pushed
the
fix/memory-leak-debugger-agent-133354
branch
3 times, most recently
from
September 11, 2026 07:52
631a354 to
0a9d4ff
Compare
Problem: The variables event_requests and pending_assembly_loads in src/mono/component/debugger-agent.c are each initialized twice (event_requests: line 792 and line 1623; pending_assembly_loads: line 1625 and line 810). The second assignment overwrites the pointer to the previously allocated GPtrArray, so the first allocation is leaked. Solution: Added guards so that the GPtrArray is created only when the corresponding variable has not been initialized yet. Signed-off-by: [email protected] Signed-off-by: [email protected]
samitistfobos-dev
force-pushed
the
fix/memory-leak-debugger-agent-133354
branch
from
September 11, 2026 07:52
0a9d4ff to
19b0c1b
Compare
Member
|
/ba-g Windows x64 Mono minijit failures reproduce on main build 1592254 with the same 46 work items crashing with 0xC0000409 FAST_FAIL_SET_CONTEXT_DENIED; unrelated to this debugger-agent allocation change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: MEMORY_LEAK
Problem:
The variables event_requests and pending_assembly_loads in src/mono/component/debugger-agent.c are each initialized twice (event_requests: line 792 and line 1623; pending_assembly_loads: line 1625 and line 810). The second assignment overwrites the pointer to the previously allocated GPtrArray, so the first allocation is leaked.
Solution:
Added guards so that the GPtrArray is created only when the corresponding variable has not been initialized yet.
Signed-off-by: [email protected]
Signed-off-by: [email protected]