Repository navigation
Update DictionaryExpansion test to use ConditionalFact(EmitSupported) - #133574
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Skipping the entire test when Reflection.Emit is unavailable likely drops non-Emit coverage that could still run, and the test should ideally be split to preserve that coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the DictionaryExpansion loader/classloader test to be gated by Reflection.Emit availability, replacing the previous NativeAOT-specific skip with ConditionalFact(Utilities.IsReflectionEmitSupported) so the test is skipped on any runtime/configuration where dynamic code isn’t supported.
Changes:
- Removed the NativeAOT
ActiveIssuegate for runtimelab#154. - Replaced
[Fact]with[ConditionalFact(typeof(Utilities), nameof(Utilities.IsReflectionEmitSupported))]for the test entrypoint while keeping the Mono Mini/FullAOTActiveIssue.
File summaries
| File | Description |
|---|---|
| src/tests/Loader/classloader/DictionaryExpansion/DictionaryExpansion.cs | Gates the test entrypoint on Reflection.Emit support via ConditionalFact. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
jkotas
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves dotnet/runtimelab#154. Nothing else left.