Repository navigation
[cDAC] implement GetVersionId - #133535
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
noahfalk
approved these changes
Sep 9, 2026
Qualify System.Guid so the cDAC unit tests compile in CI configurations without implicit System imports. Co-authored-by: Copilot <[email protected]> Copilot-Session: 62628c2d-6b16-4c8a-997e-adfcd2c69966
noahfalk
approved these changes
Sep 10, 2026
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The missing-metadata path must return the specific CORDBG_E_MISSING_METADATA result.
Review tier: Lite
Findings: None
What changed in this PR
Implements IXCLRDataModule.GetVersionId using ECMA metadata and adds cross-architecture unit coverage.
Changes:
- Adds MVID retrieval and HRESULT handling.
- Tests successful retrieval and null-pointer validation.
- Supports custom MVIDs in test metadata.
| File | Summary |
|---|---|
src/native/managed/cdac/tests/UnitTests/IXCLRDataProcessTests.cs |
Adds MVID retrieval and error-handling tests. |
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataModule.cs |
Implements GetVersionId; missing metadata must return CORDBG_E_MISSING_METADATA instead of E_NOTIMPL. |
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.