Skip to content

Add test quarantine skill - #133530

Merged
lewing merged 1 commit into
dotnet:mainfrom
lewing:lewing-activeissue-test-skill
Sep 10, 2026
Merged

lewing merged 1 commit into
dotnet:mainfrom
lewing:lewing-activeissue-test-skill

Conversation

@lewing

@lewing lewing commented Sep 9, 2026

Copy link
Copy Markdown
Member

Recent test-disable work has repeatedly run into the same traps: suppressing more coverage than the failure requires, choosing execution-time attributes for pre-execution failures, and overlooking merged-runner behavior. This adds a repository skill that turns those lessons into a reusable, pattern-first quarantine workflow.

The skill guides agents to:

  • classify the failure phase and resolve the narrowest failing unit before editing
  • preserve passing theory rows, sibling subtests, runtimes, platforms, and test modes
  • select the appropriate xUnit or runtime-test project mechanism
  • account for process-isolation and merged-runner limitations
  • use grep-discoverable ActiveIssue comments for non-attribute exclusions
  • add the disabled-test label to every referenced issue after the quarantine PR merges

It also adds 11 eval scenarios covering configuration predicates, partial theories, pre-execution failures, custom entry points, hidden merged-runner failures, stress-mode filtering, umbrella subtests, issue hygiene, and stop conditions.

Validation: the repository's official skill validator passes for all skills.

Note

This pull request description was generated with GitHub Copilot.

Co-authored-by: Copilot App <[email protected]>
@github-actions github-actions Bot added the area-skills Agent Skills label Sep 9, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
15 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

It adds a documentation-only skill plus eval definitions, and the concrete guidance aligns with existing runtime test infrastructure behavior (e.g., ActiveIssue condition composition).

Review tier: Lite
Findings: None

What changed in this PR

Adds a new repository skill (test-quarantine) that provides a pattern-first workflow for narrowly quarantining failing tests (including merged-runner/runtime-test scenarios) while preserving unaffected coverage, along with evaluator scenarios to validate expected agent behavior.

Changes:

  • Add a new skill document describing a failure-phase-first quarantine decision process, with guidance on preserving coverage and choosing the narrowest mechanism.
  • Add 11 eval scenarios covering common quarantine pitfalls (partial theories, pre-execution failures, merged runners, issue hygiene, etc.).
File Description
.github/​skills/​test-quarantine/​SKILL.md Defines the “narrow quarantine” workflow, mechanisms, and validation/stop-signal guidance for disabling tests against active issues.
.github/​skills/​test-quarantine/​evals/​evals.json Adds evaluation prompts/assertions to validate the skill’s expected quarantine recommendations across key scenarios.

@lewing
lewing marked this pull request as ready for review September 9, 2026 21:00
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
15 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@lewing
lewing merged commit 9c868a6 into dotnet:main Sep 10, 2026
27 checks passed
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Sep 14, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-skills Agent Skills

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants