Repository navigation
Improve GC allocation failure diagnostics - #133484
Merged
Merged
Conversation
Co-authored-by: mrek-msft <[email protected]>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
github-actions
Bot
added
the
area-ExceptionHandling-coreclr
mrek-msft
marked this pull request as ready for review
September 9, 2026 12:47
mrek-msft
added
area-GC-coreclr
and removed
area-ExceptionHandling-coreclr
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @anicka-net, @dotnet/gc |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is localized to test diagnostics, compiles cleanly, and improves failure visibility without altering the test’s pass/fail logic.
Pull request overview
This PR improves diagnostics in the GC allocation regression test by including full exception details in the failure output, making allocation failures easier to debug from CI logs.
Changes:
- Capture the thrown exception in the allocation loop.
- Print the exception via interpolated string formatting so the output includes exception type, message, and stack trace (
ex.ToString()).
File summaries
| File | Description |
|---|---|
| src/tests/GC/Regressions/v2.0-rtm/544701/544701.cs | Enhance allocation failure logging by printing the captured exception details. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
janvorli
approved these changes
Sep 10, 2026
rzikm
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the allocation regression test’s exception output so failures reveal what happened inside the test instead of only reporting the allocation size.