Repository navigation
Enable NativeAOT callback stress coverage without SEH interop - #133403
Merged
MichalStrehovsky merged 1 commit intoSep 9, 2026
Merged
Conversation
Gate native exception propagation on IsExceptionInteropSupported instead of skipping the whole test. Use the existing native-library path helper so the resolver works with the NativeAOT test layout. Co-authored-by: Copilot <[email protected]> Copilot-Session: 3dea65e4-6bec-47a1-b938-b02f43d8a0bb
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small, test-scoped, and align with existing helper patterns (GetFullPath / IsExceptionInteropSupported) used elsewhere in the interop test suite.
Pull request overview
This PR updates the NativeLibrary callback stress test to run on more runtimes (notably NativeAOT) by (1) using the existing helper that resolves the native library via an explicit full path and (2) gating Windows SEH exception propagation behavior on a centralized runtime capability check rather than skipping the entire test.
Changes:
- Update the
DllImportResolverpath to load the native library viaNativeLibraryToLoad.GetFullPath()(consistent with other NativeLibrary tests and compatible with NativeAOT layout). - Gate
RaiseException/SEHExceptionbehavior onPlatformDetection.IsExceptionInteropSupportedand treat unsupported runtimes as “covered” for the counter-based assertion. - Remove the NativeAOT-specific
[ActiveIssue]skip so the test can run under NativeAOT (while still skipping only the unsupported exception interop portion).
File summaries
| File | Description |
|---|---|
| src/tests/Interop/NativeLibrary/Callback/CallbackStressTest.cs | Uses NativeLibraryToLoad.GetFullPath() in the resolver and gates SEH interop via PlatformDetection.IsExceptionInteropSupported, enabling broader runtime coverage (incl. NativeAOT). |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
jkotas
approved these changes
Sep 8, 2026
jkoritzinsky
approved these changes
Sep 8, 2026
Member
Author
|
/ba-g mono crash was #133442 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate native exception propagation on IsExceptionInteropSupported instead of skipping the whole test. Use the existing native-library path helper so the resolver works with the NativeAOT test layout.