Repository navigation
Enable SuppressGCTransition tests on NativeAOT - #133402
Merged
MichalStrehovsky merged 1 commit intoSep 9, 2026
Merged
MichalStrehovsky merged 1 commit into
MichalStrehovsky merged 1 commit into
Conversation
Account for the NativeAOT executable subdirectory when locating native test assets and remove the Assembly.Location-related exclusion. Co-authored-by: Copilot <[email protected]> Copilot-Session: 3dea65e4-6bec-47a1-b938-b02f43d8a0bb
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated NativeAOT path logic likely needs to avoid Assembly.Location and be more robust/consistent by probing both AppContext.BaseDirectory and its parent to match other tests and prevent layout-dependent failures.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Enables SuppressGCTransition interop tests to run under NativeAOT by adjusting how the test locates its native library, and removes the NativeAOT-specific ActiveIssue exclusion now that the test is intended to run there.
Changes:
- Adjust native library probing logic to account for NativeAOT output layout differences.
- Remove the
ActiveIssuegate that disabled the test on NativeAOT.
File summaries
| File | Description |
|---|---|
| src/tests/Interop/SuppressGCTransition/SuppressGCTransitionTest.cs | Updates native library location logic for NativeAOT and removes the NativeAOT ActiveIssue skip. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
jkotas
approved these changes
Sep 8, 2026
jkoritzinsky
approved these changes
Sep 8, 2026
Member
Author
|
/ba-g mono crash was known and addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Account for the NativeAOT executable subdirectory when locating native test assets and remove the Assembly.Location-related exclusion.